Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc values support for ES 5 and ES 6 #82207

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Add doc values support for ES 5 and ES 6 #82207

merged 6 commits into from
Jan 10, 2022

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jan 4, 2022

Adds support for reading doc values formats of ES 5 and 6.

Relates #81210

@ywelsch ywelsch added the :Search/Search Search-related issues that do not fall into other categories label Jan 4, 2022
@ywelsch ywelsch marked this pull request as ready for review January 5, 2022 08:49
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jan 5, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@ywelsch ywelsch requested a review from dnhatn January 5, 2022 09:33
dnhatn
dnhatn approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can move Lucene54DocValuesConsumer and many LegacyXXX classes (those are used only by Lucene54DocValuesConsume) to tests?

...in/old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/BWCCodec.java Show resolved Hide resolved
@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 10, 2022

Thanks for the review, Nhat! Same as for Lucene70Codec, I'm leaving the write path for doc values in, so that I have the possibility to implement deletion of docs in the future.

@ywelsch ywelsch merged commit c55a460 into elastic:master Jan 10, 2022
@ywelsch ywelsch mentioned this pull request Feb 22, 2022
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywelsch @elasticmachine @dnhatn @elasticsearchmachine